Store filter cache statistics at the shard level instead of index. #11886
+20
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm good with the change, I just wonder if we should use Guice to instantiate it. We don't expose custom classes setting anyway. Can we instantiate it in the IndexShard constructor? This means that we could pass in some settings in the future (like the minimum segment size etc.) |
jpountz
force-pushed
the
fix/shard_filter_cache_stats
branch
from
14da97c
to
bbc27ad
Compare
|
Thanks @bleskes you made a very good point. I rebased against master which changed a bit after the cache renamings, and applied your suggestion. |
| @@ -19,6 +19,8 @@ | |||
|
|
|||
| package org.elasticsearch.index.shard; | |||
|
|
|||
| import org.apache.lucene.search.QueryCachingPolicy; | |||
Today we keep track of how often filters are used at the index level in order to decide whether they should be cached or not. This is an issue if you have several shards of the same index on the same node as it will multiply statistics by the number of shards that you have for this index on the node, which defeats the purpose of waiting for a filter to be reused before caching them.
jpountz
force-pushed
the
fix/shard_filter_cache_stats
branch
from
8b8948d
to
ccaf846
Compare
jpountz
added a commit
that referenced
this pull request
Jun 29, 2015
Store filter cache statistics at the shard level instead of index.
|
for completeness - LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we keep track of how often filters are used at the index level in order
to decide whether they should be cached or not. This is an issue if you have
several shards of the same index on the same node as it will multiply statistics
by the number of shards that you have for this index on the node, which defeats
the purpose of waiting for a filter to be reused before caching it.