Parse aliases at search time and never cache parsed alias filters #11930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpountz please could you review |
|
Just discussed it with @martijnvg. With this pull request, we make use of two hacks in order to make sure that the parsed filter is what we expect:
I like parsing aliases filters as late as possible, but I'm not happy with having both these hacks. It seems to me that we could make things work without adding more methods to QueryParseContext and just use the same rewrite hack that we use for date range queries. |
martijnvg
force-pushed
the
parse_alias_filters_at_search_time
branch
from
2c7bdf5
to
47f0cee
Compare
|
@jpountz I updated the PR and used the dummy query hack in all places where last minute query parsing needs to happen. |
|
LGTM |
martijnvg
force-pushed
the
parse_alias_filters_at_search_time
branch
3 times, most recently
from
91e5cd9
to
f795f70
Compare
…lters The work around for resolving `now` doesn't need to be used for aliases, becuase alias filters are parsed at search time. However it can't be removed, because the percolator relies on it. Parent/child can be specified again in alias filters, this now works again because alias filters are parsed at search time. Parent/child will also use the late query parse work around, to make sure to do the final preparations when the search context is around. This allows the aliases api to validate the parent/child queries without failing because there is no search context. Closes elastic#10485
martijnvg
force-pushed
the
parse_alias_filters_at_search_time
branch
from
f795f70
to
53874bf
Compare
clintongormley
added
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the alias code. The time spend on alias filter parsing is significantly lower compared to the execution time of a search request. Pre parsing alias filters and caching the parsed version at alias creation time isn't worth the effort (code complexity and memory).
Also:
nowin queries doesn't need to be used for aliases, becuase alias filters are parsed at search time. However it can't be removed, because the percolator relies on it.PR for #10485