Parameterized exception messages #11981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks for doing this |
|
Neat idea reusing the logging message formatter for exceptions. Nice for consistency. I see a lot of |
Added dynamic arguments to `ElasticsearchException`, `ElasticsearchParseException` and `ElasticsearchTimeoutException`. This helps keeping the exception messages clean and readable and promotes consistency around wrapping dynamic args with `[` and `]`. This is just the start, we need to propagate this to all exceptions deriving from `ElasticsearchException`. Also, work started on standardizing on lower case logging & exception messages. We need to be consistent here... - Uses the same `LoggerMessageFormat` as used by our logging infrastructure.
now that's a neat idea as well :) I'll get this one in first and take it from there |
Cool! |
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dynamic arguments to
ElasticsearchException,ElasticsearchParseExceptionandElasticsearchTimeoutException.This helps keeping the exception messages clean and readable and promotes consistency around wrapping dynamic args with
[and].This is just the start, we need to propagate this to all exceptions deriving from
ElasticsearchException. Also, work started on standardizing on lower case logging & exception messages. We need to be consistent here...LoggerMessageFormatas used by our logging infrastructure.