Give a better exception when a jar contains same classfile twice. #12093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And ignore the known issue with xmlbeans for now... though it may cause us issues ultimately: https://issues.apache.org/jira/browse/XMLBEANS-499
|
LGTM ... I had no idea a .zip file was allowed to have exactly the same name more than once! |
|
I opened https://issues.apache.org/jira/browse/TIKA-1675 just to try to make the issue more well known at least. I am not sure if tika can remove the dependency but the bug has sat unfixed for a long time. |
rmuir
added a commit
that referenced
this pull request
Jul 7, 2015
Give a better exception when a jar contains same classfile twice.
clintongormley
added
>enhancement
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And ignore the known issue with xmlbeans for now... though it may
cause us issues ultimately: https://issues.apache.org/jira/browse/XMLBEANS-499