Clean up handling of missing values when merging shard results on the coordinating node. #12127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… coordinating node. Today shards are responsible for producing one sort value per document, which is later used on the coordinating node to resolve the global top documents. However, this is problematic on string fields with `missing: _first, order: desc` or `missing: _last, order: asc` given that there is no such thing as a string that compares greater than any other string. Today we use a string containing a single code point which is the maximum allowed code point but this is a hack: instead we should inform the coordinating node that the document had no value and let it figure out how it should be sorted depending on whether missing values should be sorted first or last. Close elastic#9155
jpountz
added
v2.0.0-beta1
review
:Search/Search
|
LGTM |
jpountz
added a commit
that referenced
this pull request
Jul 9, 2015
Clean up handling of missing values when merging shard results on the coordinating node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today shards are responsible for producing one sort value per document, which
is later used on the coordinating node to resolve the global top documents.
However, this is problematic on string fields with
missing: _first, order: descormissing: _last, order: ascgiven that thereis no such thing as a string that compares greater than any other string. Today
we use a string containing a single code point which is the maximum allowed code
point but this is a hack: instead we should inform the coordinating node that
the document had no value and let it figure out how it should be sorted
depending on whether missing values should be sorted first or last.
Close #9155