Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PluginManager screws up file permissions for stuff in bin/ #12142

Closed
rmuir opened this issue Jul 9, 2015 · 1 comment
Closed

PluginManager screws up file permissions for stuff in bin/ #12142

rmuir opened this issue Jul 9, 2015 · 1 comment
Assignees
@rmuir
Labels
>bug v2.0.0-beta1

Comments

@rmuir
Copy link
Contributor

rmuir commented Jul 9, 2015

It gives them only execute permission. But instead it should add execute bit, not remove everything else.
@rmuir rmuir self-assigned this Jul 9, 2015
rmuir added a commit to rmuir/elasticsearch that referenced this issue Jul 9, 2015
@rmuir
Fix pluginmanager permissions for bin/ scripts
dfbe108 
Today it will remove all permissions and only set execute bit:

    ---x--x--x

Instead we should preserve existing permissions, and just add
read and execute to whatever is there.

Closes elastic#12142
@rmuir rmuir mentioned this issue Jul 9, 2015
Merged
@rmuir
Copy link
Contributor Author

rmuir commented Jul 9, 2015

This is a 2.0-only problem. 1.x uses a different mechanism from java.io.File to add executable perms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmuir rmuir

Labels
>bug v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmuir