Backport to 1.7 - Snapshot info should contain version of elasticsearch that created the snapshot #12162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
>enhancement
review
:Distributed/Snapshot/Restore
| @@ -260,6 +278,9 @@ public void readFrom(StreamInput in) throws IOException { | |||
| } else { | |||
| shardFailures = ImmutableList.of(); | |||
| } | |||
| if(in.getVersion().onOrAfter(Version.V_1_7_0)) { | |||
There was a problem hiding this comment.
Super-minor, but missing a space between if and ( here.
|
LGTM, left two bikeshed comments. |
…e snapshot This information was stored with the snapshot but wasn't available on the interface. Knowing the version of elasticsearch that created the snapshot can be useful to determine the minimal version of the cluster that is required in order to restore this snapshot. Closes elastic#11980
imotov
force-pushed
the
issue-11980-add-version-to-snapshot-info-1.x
branch
from
f9ed0b5
to
cdfdd76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #11985 to 1.7
This information was stored with the snapshot but wasn't available on the interface. Knowing the version of elasticsearch that created the snapshot can be useful to determine the minimal version of the cluster that is required in order to restore this snapshot.
Closes #11980