Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup concrete indices and alias information via a single lookup #12173

Closed
martijnvg opened this issue Jul 9, 2015 · 4 comments
Closed

Lookup concrete indices and alias information via a single lookup #12173

martijnvg opened this issue Jul 9, 2015 · 4 comments
Labels
help wanted adoptme :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team won't fix

Comments

@martijnvg
Copy link
Member

If a request is accepted by the coordination node we lookup the concrete indices, potential aliases and whether an alias has a filter up via several lookups from the cluster metadata. Also when checking for cluster blocks we do a lookup too.

All this can be done via a single lookup and if we change the transport action api we pass this information too all the places that need it.

Doing this via a single lookup cleans things up (no need for MetaData#filteringAliases(...) and MetaData#resolveSearchRouting(...) methods) but in cases where there are many aliases and indices this can speed things up too.

Follow up issue for #12058

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@javanna
Copy link
Member

javanna commented Apr 8, 2019

I wonder if this is (at least partially) addressed by #40263. @jpountz what do you think?

@jpountz
Copy link
Contributor

jpountz commented Apr 8, 2019

I was not aware of this issue. I think #40263 addresses the worst-case scenarios performance-wise, but @martijnvg's proposal would make things even better, and probably simpler as well I suspect.

@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@javanna
Copy link
Member

javanna commented Jun 16, 2022

Closing for lack of activity. We haven't gotten to it in 7 years, and I don't think we will get to it anytime soon either. Please reopen if you feel this is something we should prioritize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted adoptme :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team won't fix
Projects
None yet
Development

No branches or pull requests

7 participants