Term Query: Be more strict during parsing #12195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spinscale
added
review
:Search/Search
|
LGTM |
| @@ -63,6 +63,9 @@ public Query parse(QueryParseContext parseContext) throws IOException, QueryPars | |||
| // skip | |||
| } else if (token == XContentParser.Token.START_OBJECT) { | |||
| // also support a format of "term" : {"field_name" : { ... }} | |||
| if (fieldName != null) { | |||
| throw new QueryParsingException(parseContext, "[term] query does not support different field names, use [terms] query"); | |||
There was a problem hiding this comment.
I would modify the error message here, one cannot use the terms query instead against multiple fields, you should rather combine multiple term queries in a bool query I think
|
LGTM besides a minor comment |
The term query parser was too lenient during parsing and allowed to specify more than one field, even though this expected to filter only for a single field. This commit returns an exception if a query has been specified more than once. Closes elastic#12184
spinscale
force-pushed
the
1507-term-filter-parser-issue-12184
branch
from
a1d6f96
to
195c8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term query parser was too lenient during parsing and allowed to specify
more than one field, even though this expected to filter only for a single field.
This commit returns an exception if a query has been specified more than once.
Closes #12184