Add global search timeout setting #12211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
review
:Analytics/Aggregations
| @@ -148,10 +145,11 @@ | |||
| private final ParseFieldMatcher parseFieldMatcher; | |||
|
|
|||
| @Inject | |||
| public SearchService(Settings settings, ClusterService clusterService, IndicesService indicesService,IndicesWarmer indicesWarmer, ThreadPool threadPool, | |||
| public SearchService(Settings settings, SearchSettings searchSettings, ClusterService clusterService, IndicesService indicesService,IndicesWarmer indicesWarmer, ThreadPool threadPool, | |||
There was a problem hiding this comment.
can we just fold SearchSettings into SearchService we already have enough classes and abstractions I don't think we need another one.
|
I left some comments, thanks @jasontedor |
clintongormley
added
:Search/Search
This commit adds a dynamically updatable cluster-level search timeout setting. Closes #12149
| @@ -90,7 +91,7 @@ | |||
| private ScanContext scanContext; | |||
| private float queryBoost = 1.0f; | |||
| // timeout in millis | |||
| private long timeoutInMillis = -1; | |||
| private long timeoutInMillis; | |||
|
LGTM |
jasontedor
added a commit
that referenced
this pull request
Jul 17, 2015
Add global search timeout setting
jasontedor
added a commit
that referenced
this pull request
Jan 7, 2016
Add documentation for global search timeout Relates #12211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a dynamically updatable cluster-level search timeout setting. Additionally, some other search settings were moved to
org.elasticsearch.search.SearchSettings.
Closes #12149