Simplify assignToNode to only do initializing #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assert state == ShardRoutingState.UNASSIGNED : this; | ||
| state = ShardRoutingState.INITIALIZING; | ||
| currentNodeId = nodeId; | ||
| relocatingNodeId = null; |
There was a problem hiding this comment.
strictly speaking this should be need right? maybe just assert on it?
|
LGTM. Left a tiny comment. No need for another cycle. |
The method really only should do the move from unassigned to initializing, all the other moves have explicit methods like relocate
kimchy
force-pushed
the
move_assing_to_initialize
branch
from
c522c18
to
c6b110c
Compare
lcawl
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method really only should do the move from unassigned to initializing, all the other moves have explicit methods like relocate