Add _replica and _replica_first as search preference. #12244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -312,6 +316,32 @@ public ShardIterator primaryFirstActiveInitializingShardsIt() { | |||
| return new PlainShardIterator(shardId, ordered); | |||
| } | |||
|
|
|||
| public ShardIterator replicaActiveInitializingShardIt() { | |||
| if (!replicas.isEmpty() && !replicas.get(0).active() && !replicas.get(0).initializing()) { | |||
There was a problem hiding this comment.
I wouldn't rely on the order the replicas exist in for this behavior, note it works in the primary case cause there can be only one :)
|
left a couple of comments, can we also add unit tests to |
|
@kimchy thanks for taking a look! I think I misunderstood what the iterators were doing previously, but I think I have fixed it now. (and added a unit test to make sure) |
| public ShardIterator replicaActiveInitializingShardIt() { | ||
| // If the primaries are unassigned, return an empty list (there aren't | ||
| // any replicas to query anyway) | ||
| if (!primaryAsList.isEmpty() && !primaryAsList.get(0).active() && !primaryAsList.get(0).initializing()) { |
There was a problem hiding this comment.
can me extract this into a method, it is used in 3 places
There was a problem hiding this comment.
Good idea, I'll do that.
|
left few minor comments, LGTM |
dakrone
force-pushed
the
add-replica-preference
branch
from
5132419
to
aca40dd
Compare
Just like specifying `?preference=_primary`, this adds the ability to specify `?preference=_replica` or `?preference=_replica_first` on requests that support it. Resolves elastic#12222
dakrone
force-pushed
the
add-replica-preference
branch
from
aca40dd
to
a8391fc
Compare
clintongormley
added
the
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just like specifying
?preference=_primary, this adds the ability tospecify
?preference=_replicaor?preference=_replica_firstonrequests that support it.
Resolves #12222