Refactor geo_point validate_* and normalize_* for 1.7 #12300
Conversation
No need to carry 3 validate and 3 normalize options in GeoPointFieldMapping. This is just causing confusion so this change deprecates the validate_lat, validate_lon, normalize_lat, and normalize_lon options and simply uses validate and normalize, respectively. Geo filters have also been updated to include a validate and normalize option to provide consistency with the mapping defaults. Unit tests and documentation have been updated.
nknize
added
review
:Analytics/Geo
…rmed/coerce, respectively. Docs updated to reflect change
|
@clintongormley made the suggested change from normalize/validate to coerce/ignore_malformed, respectively. This PR should be ready to go for 1.71. Will need to make 2.0 changes separately since the mapping logic is completely different. |
|
@nknize i think in 2.0 we still need to maintain bwc. So we should accept the old settings when opening old indices, and translate them to the new settings. New indices should only accept the new settings. Also, once merged into master, could you open an issue to add a check for this to the migration plugin ta |
|
Closed in favour of #10248 |
|
So we're keeping this change out of 1.7.x and going straight to 2.0, right? |
|
Ahh sorry @nknize - when i was doing the release, I saw that #10248 had been merged and this one hadn't. I didn't look at the contents of the PR. OK - let's move this to 2.0. We'll need to support the old normalize* and validate* parameters for bwc, but we should automatically migrate the settings to coerce/ignore_malformed. |
nknize
changed the title
|
We discussed this today, and since these are deprecated already in the docs for 1.7 and already removed in 2.0, there's no need to refactor them for 1.7. Closing this for now, thanks @nknize! |
This PR deprecates validate_* and normalize_* options for
geo_pointfield mapping in favor of more straight-forwardvalidateandnormalizeparameters. This PR is for 1.7 only. 2.0 will completely remove these parameters.