Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search.scroll_time_in_millis might not be accurate #12345

Closed
jasontedor opened this issue Jul 20, 2015 · 0 comments
Closed

search.scroll_time_in_millis might not be accurate #12345

jasontedor opened this issue Jul 20, 2015 · 0 comments
Assignees
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1

Comments

@jasontedor
Copy link
Member

Metrics for scrolls (open scroll contexts, time scroll contexts held open, and completed scroll contexts) were added to the search stats in #9109. The time scroll contexts were held open is calculated at millisecond resolution using the time the context was created on the coordinating node. This can lead to two issues:

  1. Millisecond resolution is too coarse to accurately capture the time that very short-lived scroll contexts are held open, especially on systems with low-granualarity clocks.
  2. Discrepancies in the clocks between the coordinating node and the nodes where the scrolls are executed will lead to inaccuracies in measuring the time that the context is held open at the shard level.

Instead, an origin time in nanosecond resolution that is calculated on the executing node should be used to measure the time that scroll contexts are held open.

@jasontedor jasontedor added >bug v2.0.0-beta1 :Data Management/Stats Statistics tracking and retrieval APIs :Scroll labels Jul 20, 2015
@jasontedor jasontedor self-assigned this Jul 20, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Scroll labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Stats Statistics tracking and retrieval APIs :Search/Search Search-related issues that do not fall into other categories v2.0.0-beta1
Projects
None yet
Development

No branches or pull requests

2 participants