Add shadow indicator when using shadow replicas #12399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String maybeShadowIndicator = IndexMetaData.isIndexUsingShadowReplicas(indexMetaData.settings()) ? "s" : ""; | ||
| logger.info("[{}] creating index, cause [{}], templates {}, shards [{}]/[{}], mappings {}", | ||
| request.index(), request.cause(), templateNames, indexMetaData.numberOfShards(), | ||
| indexMetaData.numberOfReplicas() + maybeShadowIndicator, |
There was a problem hiding this comment.
couldn't you do {}{} and indexMetaData.numberOfReplicas(), maybeShadowIndicator instead?
There was a problem hiding this comment.
Ah yeah, that's probably better than string concatenation.
There was a problem hiding this comment.
Pushed another commit for this
|
LGTM |
|
+1 |
clintongormley
added
>enhancement
:Core/Infra/Logging
dakrone
force-pushed
the
log-shadow-replicas
branch
from
6555c89
to
1807916
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very simple PR that changes:
Into:
When shadow replicas are used.