Consult field info before fetching field data #12403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvg
force-pushed
the
field_data_check_field_info
branch
from
9c27f80
to
3ddc0b9
Compare
|
looks good to me |
martijnvg
force-pushed
the
field_data_check_field_info
branch
from
3ddc0b9
to
e5d3a0c
Compare
… a non cached empty atomic reader.
…sed on two fields...
martijnvg
force-pushed
the
field_data_check_field_info
branch
from
e5d3a0c
to
948da82
Compare
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a field doesn't exist in field info then always return a non cached empty atomic reader.