Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make java.version mandatory for jvm plugins #12424

Merged
merged 3 commits into from Jul 24, 2015

Conversation

rmuir
Copy link
Contributor

@rmuir rmuir commented Jul 23, 2015

JarHell has a low level check, but its more of a best effort one,
only checking if X-Compile-Target-JDK is set in the manifest. This
is the case for all lucene- and elasticsearch- generated jars, but
lets just be explicit for plugins.

I also reorganized the descriptor file a bit and added a site plugin example.

JarHell has a low level check, but its more of a best effort one,
only checking if X-Compile-Target-JDK is set in the manifest. This
is the case for all lucene- and elasticsearch- generated jars, but
lets just be explicit for plugins.
@rmuir rmuir added the review label Jul 23, 2015
@rmuir
Copy link
Contributor Author

rmuir commented Jul 23, 2015

@clintongormley
Copy link

@rmuir docs look good to me. perhaps just add a note that elasticsearch.version can also be specified for site plugins, as they have dependencies on the APIs in a particular version?

@rmuir
Copy link
Contributor Author

rmuir commented Jul 23, 2015

@rmuir docs look good to me. perhaps just add a note that elasticsearch.version can also be specified for site plugins, as they have dependencies on the APIs in a particular version?

But currently this property is only functional for jvm plugins. If we want to make it optional for site plugins then we need to implement that.

@jasontedor
Copy link
Member

@rmuir I left a minor comment, otherwise it LGTM.

rmuir added a commit that referenced this pull request Jul 24, 2015
make java.version mandatory for jvm plugins
@rmuir rmuir merged commit 219f481 into elastic:master Jul 24, 2015
@clintongormley clintongormley added >breaking :Core/Infra/Plugins Plugin API and infrastructure labels Jul 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants