Reroute shards when a node goes under disk watermarks #12452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Boolean passedLow = nodeHasPassedLowWatermark.get(node); | ||
|
|
||
| if ((passedHigh != null && passedHigh) || (passedLow != null && passedLow)) { | ||
| // The entry has previously been over the high or |
|
Left one minor comment. Otherwise LGTM. |
dakrone
force-pushed
the
reroute-on-below-watermark
branch
from
c98bffb
to
8a62dc7
Compare
Previously we issued a reroute when a node went over the high watermark in order to move shards away from the node. This change tracks nodes that have previously been over the high or low watermarks and issues a reroute when the node goes back underneath the watermark. This allows shards that may be unassigned to be assigned back to a node that was previously over the low watermark but no longer is. Resolves elastic#12422
dakrone
force-pushed
the
reroute-on-below-watermark
branch
from
8a62dc7
to
5a8356c
Compare
lcawl
added
:Distributed/Distributed
clintongormley
added
:Distributed/Allocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we issued a reroute when a node went over the high watermark
in order to move shards away from the node. This change tracks nodes
that have previously been over the high or low watermarks and issues a
reroute when the node goes back underneath the watermark.
This allows shards that may be unassigned to be assigned back to a node
that was previously over the low watermark but no longer is.
Resolves #12422