Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent awareness allocation #12522

Closed
masaruh opened this issue Jul 29, 2015 · 0 comments
Closed

Inconsistent awareness allocation #12522

masaruh opened this issue Jul 29, 2015 · 0 comments
Labels
discuss :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes)

Comments

@masaruh
Copy link
Contributor

masaruh commented Jul 29, 2015

When awareness attribute is unbalanced, behavior of shard allocation is inconsistent depending on how many shards are already started.

Reproduction: https://gist.github.com/masaruh/63db5a030220a26cc2a8
It allocates all shards of an index to nodes on creation but when one of nodes leaves and comes back, it doesn't allocate previously allocated shard back to the node anymore.
(All shards shouldn't be allocated in the first place?)

Probably because AwarenessAllocationDecider doesn't take initializing shards into consideration when it checks if shards can be allocated on nodes (https://github.com/elastic/elasticsearch/blob/v1.7.0/src/main/java/org/elasticsearch/cluster/routing/allocation/decider/AwarenessAllocationDecider.java#L189-L198)?

Looks to be related to #12431.
@masaruh masaruh mentioned this issue Jul 30, 2015
Merged
masaruh added a commit to masaruh/elasticsearch that referenced this issue Sep 11, 2015
@masaruh
Take initializing shards into consideration during awareness allocation
5ae00a6 
It makes decision consistent.
Fixes elastic#12522
masaruh added a commit that referenced this issue Sep 11, 2015
@masaruh
Take initializing shards into consideration during awareness allocation
9910b99 
It makes decision consistent.
Fixes #12522
masaruh added a commit that referenced this issue Sep 11, 2015
@masaruh
Take initializing shards into consideration during awareness allocation
f480ad7 
It makes decision consistent.
Fixes #12522
masaruh added a commit that referenced this issue Sep 11, 2015
@masaruh
Take initializing shards into consideration during awareness allocation
d0eea80 
It makes decision consistent.
Fixes #12522
@lcawl lcawl added :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. and removed :Allocation labels Feb 13, 2018
@clintongormley clintongormley added :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) and removed :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @masaruh @lcawl