Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup plugin installation in bats tests #12564

Closed
jaymode opened this issue Jul 30, 2015 · 1 comment
Closed

cleanup plugin installation in bats tests #12564

jaymode opened this issue Jul 30, 2015 · 1 comment
Labels
help wanted adoptme >test Issues or PRs that are addressing/adding tests

Comments

@jaymode
Copy link
Member

jaymode commented Jul 30, 2015

When reviewing #12508, I noticed that the plugin installation in the bats tests used the plugin name typically used when installing without specifying the url:

/tmp/elasticsearch/bin/plugin install elasticsearch/shield/latest -u "file://$SHIELD_ZIP"

typically we say to install with just shield as the name when specifying the URL. I think we should cleanup the installation to be more realistic.
@jaymode jaymode added >test Issues or PRs that are addressing/adding tests v2.0.0-beta1 labels Jul 30, 2015
@clintongormley clintongormley added the help wanted adoptme label Aug 5, 2015
@clintongormley clintongormley mentioned this issue Aug 10, 2015
Closed
16 tasks
@spinscale
Copy link
Contributor

closing in favor of #12651

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted adoptme >test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@clintongormley @spinscale @jaymode