Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check if FieldMappers exists #12635

Merged
merged 1 commit into from Sep 8, 2015
Merged

Add a check if FieldMappers exists #12635

merged 1 commit into from Sep 8, 2015

Conversation

SergVro
Copy link

@SergVro SergVro commented Aug 4, 2015

Closes #12572: Add a simple check if FieldMappers is not null

@rjernst
Copy link
Member

rjernst commented Aug 4, 2015

@SergVro Can you add a test? You can see how it is tested on master here:
https://github.com/elastic/elasticsearch/blob/master/core/src/test/java/org/elasticsearch/search/query/ExistsMissingIT.java#L49

I think the same change should be in the MissingFilterParser as well?

@SergVro
Copy link
Author

SergVro commented Aug 5, 2015

@rjernst I have added the same fix in the MissingFilterParser and tests for both filters

@nik9000
Copy link
Member

nik9000 commented Aug 7, 2015

Note: this fix should apply to 1.6 and 1.7.

rjernst added a commit that referenced this pull request Sep 8, 2015
Add a check if FieldMappers exists
@rjernst rjernst merged commit e65c384 into elastic:1.7 Sep 8, 2015
@rjernst
Copy link
Member

rjernst commented Sep 8, 2015

@SergVro Thanks, I merged this to 1.7. There won't be a 1.6.3 so I have not merged to there.

@rjernst rjernst removed the v1.6.3 label Sep 8, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search/Search Search-related issues that do not fall into other categories v1.7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants