Speed up the function_score query when scores are not needed.
#12693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change improves the `function_score` query to not compute scores at all when they are not needed, and to not compute scores on the underlying query when the combine function is to replace the score with the scores of the functions.
jpountz
added
>enhancement
review
:Search/Search
| @@ -127,6 +127,13 @@ public Explanation explainScore(int docId, Explanation subQueryScore) throws IOE | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean needsScores() { | |||
| // Scripts might use _score so we return true here | |||
| // TODO: Make scripts able to tell us whether they use scores | |||
There was a problem hiding this comment.
By the way: lucene expressions "know this"
There was a problem hiding this comment.
As we speak I'm working on another change to expose this. :-)
|
+1, wonderful |
|
LGTM. I like how you push the hard part of the TODO closer to the problem and get wins on the "easier" parts. |
jpountz
added a commit
that referenced
this pull request
Aug 6, 2015
…score_query_when_replacing_score Speed up the `function_score` query when scores are not needed.
jpountz
deleted the
enhancement/speed_up_function_score_query_when_replacing_score
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves the
function_scorequery to not compute scores at allwhen they are not needed, and to not compute scores on the underlying query
when the combine function is to replace the score with the scores of the
functions.