Allow scripts to expose whether they use the _score.
#12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new API to allow scripts to say whether they need scores. In practice, only the `expression` script engine makes use of it correctly, other engines just return `true` since they can't predict whether they'll need scores. This should make scripted aggregations and `function_query` faster as we'll now be able to pass needsScores=false to Query.createWeight.
jpountz
added
>enhancement
review
:Analytics/Aggregations
|
Native scripts can also make use of this optimization. But since we can't detect it like we do for |
|
Looks great. This is an important optimization to allow the whole rest of the query to be cached. |
jpountz
removed
:Analytics/Aggregations
|
LGTM |
jpountz
added a commit
that referenced
this pull request
Aug 6, 2015
Allow scripts to expose whether they use the `_score`.
imotov
added a commit
to imotov/elasticsearch-native-script-example
that referenced
this pull request
Aug 14, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new API to allow scripts to say whether they need scores.
In practice, only the
expressionscript engine makes use of it correctly,other engines just return
truesince they can't predict whether they'llneed scores. This should make scripted aggregations and
function_queryfaster as we'll now be able to pass needsScores=false to Query.createWeight.