Escape CLI parameters when starting elasticsearch

[xuzha]

I'm not sure if I should do this.

Closes #12677

[dakrone]

I actually think maybe we should switch to \"$@\" instead of \"$*\", see http://www.bashguru.com/2009/11/how-to-pass-arguments-to-shell-script.html for the difference when quoted (particularly for files with spaces in the name).

[xuzha]

Hmm, probably I am not quite understand. But I don't think there is any difference between \"$*\" and \"$@\", we escape the double quotes there which will be passed into java program, and $* and $@ became same.

Try this dirty bash script

#!/bin/bash

function print_args_at {
    printf "%s\n" "$@"
}

function print_args_star {
    printf "%s\n" "$*"
}

function print_args_star1 {
    printf "%s\n" \"$*\"
}

function print_args_star2 {
    printf "%s\n" \"$@\"
}

print_args_at "one" "two three" "four"
print_args_star "one" "two three" "four"
print_args_star1 "one" "two three" "four"
print_args_star2 "one" "two three" "four"

[rmuir]

I am working to make integration tests always use spaces in directory names (some fixes are needed) to blast out these bugs. But I agree with @dakrone here.

[xuzha]

OK, thanks guys, updated.

[clintongormley]

@spinscale @xuzha is this PR related to #12709 ?

[spinscale]

Does this work for you? ./bin/elasticsearch -Des.pidfile="/path/with space/es.pid" - results in this error to me:

Exception in thread "main" java.nio.file.AccessDeniedException: /path
    at sun.nio.fs.UnixException.translateToIOException(UnixException.java:84)
    at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102)
    at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107)
    at sun.nio.fs.UnixFileSystemProvider.createDirectory(UnixFileSystemProvider.java:384)
    at java.nio.file.Files.createDirectory(Files.java:674)
    at java.nio.file.Files.createAndCheckIsDirectory(Files.jav
...

Also, calling something like /bin/elasticsearch --http.cors.enabled true --http.cors.allow-origin 'foo' results in this as only a single argument is passed?

ERROR: Parameter [http.cors.enabled true http.cors.allow-origin foo] needs value

[xuzha]

@spinscale You are right, adding " " make them only a single argument is passed. But AccessDeniedException is the expected exception, right?

Anyway, Robert has a much better fix 12710. Ill just close this dumb one.