Add script compilation stats #12733
Merged
Add script compilation stats #12733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>feature
v2.0.0-beta1
review
:Data Management/Stats
| @@ -387,6 +387,63 @@ public void testCompileNonRegisteredContext() throws IOException { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Great test! Maybe one more that tests total compiles 2 or 3 or something - just more than one. So we can see how the number doesn't increment in weird ways.
There was a problem hiding this comment.
Good point! I added such a test. I'll squash before pushing to master.
|
LGTM, this is nice to have! |
This commit adds basic support to track the number of times scripts are compiled and compiled scripts are evicted from the script cache. These statistics are tracked at the node level. Closes #12673
jasontedor
added a commit
that referenced
this pull request
Aug 7, 2015
Add script compilation stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds basic support to track the number of times scripts are
compiled and compiled scripts are evicted from the script cache. These
statistics are tracked at the node level.
Closes #12673