Fix field type compatiblity check to work when only one previous type exists #12779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vious type exists. This was a straight up bug found in elastic#12753. If only one type existed, the compatibility check for a new type was not strict, so changes to an updateable setting like search_analyzer got through (but only partially). This change fixes the check and adds tests (which were previously a TODO). This also fixes a bug in dynamic field creation which woudln't copy fielddata settings when duplicating a pre-existing field with the same name. closes elastic#12753
rjernst
added
v2.0.0-beta1
:Search/Mapping
|
LGTM |
rjernst
added a commit
that referenced
this pull request
Aug 11, 2015
Fix field type compatiblity check to work when only one previous type exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a straight up bug found in #12753. If only one type existed,
the compatibility check for a new type was not strict, so changes to
an updateable setting like search_analyzer got through (but only
partially). This change fixes the check and adds tests (which were
previously a TODO).
This also fixes a bug in dynamic field creation which woudln't copy
fielddata settings when duplicating a pre-existing field with the
same name.
closes #12753