Adds a setting to control source output in indexing slowlog #12806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik9000
added
review
:Search/Mapping
|
@jpountz, this could use a review. |
| * high surrogates. | ||
| */ | ||
| public static String cleanTruncate(String s, int length) { | ||
| if (length > s.length()) { |
There was a problem hiding this comment.
Yeah - no need to substring in the equals case either.
clintongormley
added
v2.0.0-beta1
and removed
:Search/Mapping
| @@ -55,18 +62,27 @@ | |||
| public static final String INDEX_INDEXING_SLOWLOG_THRESHOLD_INDEX_TRACE = INDEX_INDEXING_SLOWLOG_PREFIX +".threshold.index.trace"; | |||
| public static final String INDEX_INDEXING_SLOWLOG_REFORMAT = INDEX_INDEXING_SLOWLOG_PREFIX +".reformat"; | |||
| public static final String INDEX_INDEXING_SLOWLOG_LEVEL = INDEX_INDEXING_SLOWLOG_PREFIX +".level"; | |||
| public static final String INDEX_INDEXING_SLOWLOG_MAX_SOURCE_CHARS_TO_LOG = INDEX_INDEXING_SLOWLOG_PREFIX + ".source"; | |||
There was a problem hiding this comment.
maybe also rename the setting? (in addition to the constant)
There was a problem hiding this comment.
I kinda like how simple the setting is though. It makes sense because you can set it to false and get no source and true and get it all....
|
LGTM |
nik9000
force-pushed
the
slowlog
branch
3 times, most recently
from
102dfc7
to
b391bfe
Compare
Instead of logging the entire `_source` in the indexing slowlog we log by default just the first 1000 characters - this is controlled by the `index.indexing.slowlog.source` settings and can be set to `true` to log the whole `_source`, `false` to log none of it, and a number to log at most that many characters. Closes elastic#4485
nik9000
added a commit
that referenced
this pull request
Aug 11, 2015
Adds a setting to control source output in indexing slowlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logging the entire _source in the indexing slowlog we log by default just the first 1000 characters - this is controlled by the
index.indexing.slowlog.sourcesettings and can be set totrueto log the whole _source,falseto log none of it, and a number to log at most that many characters.Closes #4485