Enhancement/terms lookup fixes #12870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>enhancement
review
:Core/Infra/Transport API
| * @deprecated use [bool] query instead | ||
| */ | ||
| @Deprecated | ||
| public TermsQueryBuilder disableCoord(boolean disableCoord) { |
There was a problem hiding this comment.
Thanks for doing this, can you also make the parser use a ParseField that marks it as deprecated?
javanna
force-pushed
the
enhancement/terms_lookup_fixes
branch
from
86dce9a
to
f8986b4
Compare
|
LGTM |
TermsQueryParser doesn't support the cache field anymore, so if it gets set through java api, the subsequent parsing of that query will throw error
…TermsQueryBuilder TermsQueryParser still parses those values although deprecated. These need to be present in the java api as well to get ready for the query refactoring, where the builders are the intermediate query format that we parse our json queries into. Whatever the parser supports need to be supported by the builder as well.
javanna
force-pushed
the
enhancement/terms_lookup_fixes
branch
from
f8986b4
to
64bfbd2
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Aug 14, 2015
TermsQueryParser doesn't support the cache field anymore, so if it gets set through java api, the subsequent parsing of that query will throw error Relates to elastic#12870
|
Marking this as breaking as the removal of the setter for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #12042 (comment) .