Expose points_only option through geo_shape field mapper #12893
Conversation
nknize
added
:Analytics/Geo
| ensureGreen(); | ||
|
|
||
| // test exception handling by attempting to insert a random polygon | ||
| ShapeBuilder shape = RandomShapeGenerator.createShape(random()); |
There was a problem hiding this comment.
Just so I understand, the random shape could or could not be a ploygon, so if it is a polygon we want to make sure an exception is thrown (and then finish the test), otherwise we want to use it in a query. Correct?
There was a problem hiding this comment.
Good point. The comment should be more clear (and probably moved inside the catch block). RandomShapeGenerator.createShape generates a random GeoJson compliant object, so that could be one of [Point, MultiPoint, Linestring, MultiLinestring, Polygon, Multipolygon, GeometryCollection]. If the geo_shape mapping is defined with points_only : true then anything other than a Point should throw an exception. That's what we're testing here in the catch block.
|
Left two very minor comments, other than that looks good to me! |
nknize
force-pushed
the
enhancement/12856
branch
from
be4c0d0
to
95d41cc
Compare
… performance on geo_shape indexes designed to store only points. Includes updated documentation and exception handling for ensuring index integrity on points only data.
nknize
force-pushed
the
enhancement/12856
branch
from
95d41cc
to
e4e71d8
Compare
This PR adds a
points_onlyoption (defaults tofalse) to the GeoShapeFieldMapper that exposes the pointsOnly optimization in lucene's RecursivePrefixTreeStrategy. This optimization short-circuits DFS traversal when it is known that the field contains points only. To enforce this option theGeoShapeFieldMapperhas been updated to throw a MapperParsingException for anyShapethat is not of typePointwhen the option is set totrue. Randomized testing is added and docs are updated. ShapeCollection has also been updated to eventually support MultiPoint. Limitations of S4j are currently the only blocker.closes #12856