Workaround JDK bug 8034057 #12970
Closed
Workaround JDK bug 8034057 #12970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Files.getFileStore(Path) useless here! Don't complain, just try it yourself. | ||
| */ | ||
| @SuppressForbidden(reason = "works around the bugs") |
There was a problem hiding this comment.
just for kicks can we have reason = "works around https://bugs.openjdk.java.net/browse/JDK-8034057" it's just more obvious which bug is meant
|
left some minor comments LGTM otherwise |
|
LGTM too |
|
LGTM |
|
This is pretty ugly code, but the bug is even uglier, ES won't start at all, plugin installation won't work, etc. So I don't know what versions we want this in, someone other than me decide. FYI I also sent an email to nio-dev, asking about the real fix... |
|
I am ok with this going into 2.0 |
|
Fixed in e07f039 |
|
JDK backport link: https://bugs.openjdk.java.net/browse/JDK-8133891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugs.openjdk.java.net/browse/JDK-8034057, where two filesystem methods are broken for SUBST'd drive letters (this is basically where you map a local drive to another letter, like c:\foo -> d:).
These bugs won't be fixed until java 9, but its a configuration some people use on windows.