Lucene SPI support for plugins. #13051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we create a plugin's classloader, we should allow it to register things in the lucene SPI (registry of Tokenizers, TokenFilters, CharFilters, Codec, PostingsFormat, DocValuesFormat). Plugins should be able to do this so they can extend Lucene.
|
This PR works, but it would be nice to test: maybe it should be a followup. We should probably add an API somewhere (it can be internal or whatever) to dump out the contents of these registries for debugging anyway... If we did this, we could add integration tests to our current analysis plugins that they are registered correctly, and that would do the trick. |
|
LGTM |
|
+1. We should at some point add an API to Lucene that does this in one call (Lucene should know on its own which SPIs are there) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we create a plugin's classloader, we should allow it to register things in
the lucene SPI (registry of Tokenizers, TokenFilters, CharFilters, Codec,
PostingsFormat, DocValuesFormat).
Plugins should be able to do this so they can extend Lucene.