New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More portable extraction of short hostname #13109
Conversation
This probably deserves a comment or some helpful person will revert it back to |
This probably deserves a comment or some helpful person will revert it back to
Ah. Solaris 10. |
Otherwise LGTM. |
This commit increases the portability of extracting the short hostname on a Unix-like system. Closes #13107
@nik9000 Also HP-UX. I've added a comment as you requested. I also discovered in the course of testing this is on Solaris VM that combining the variable definition and export into a single line isn't supported in some shells (namely the Bourne shell which is the default shell on Solaris). I've found a more portable way to do the export as well. I've updated the pull request accordingly. |
Bleh. I'm not against just using Thanks for adding the comment - that is perfect. |
@nik9000 I've been contemplating that as well but at a minimum it is a separate issue from this one. |
More portable extraction of short hostname
Yeah, probably. |
This commit increases the portability of extracting the short hostname
on a Unix-like system.
Closes #13107