Convert upgrade action to broadcast by node #13205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
:Distributed/Network
| @@ -134,7 +134,7 @@ private final Response newResponse(Request request, AtomicReferenceArray respons | |||
| } | |||
| totalShards += unavailableShardExceptions.size(); | |||
| int failedShards = exceptions.size(); | |||
| return newResponse(request, totalShards, successfulShards, failedShards, broadcastByNodeResponses, exceptions); | |||
| return newResponse(request, totalShards, successfulShards, failedShards, broadcastByNodeResponses, exceptions, clusterService.state()); | |||
There was a problem hiding this comment.
can we tunnel through the cluster state used in the action? that way we don't need to worry about consistency between the two (concurrent index deletion etc.)
|
Thx @jasontedor . Left one minor comment. |
Several shard-level operations that previously broadcasted a request per shard were converted to broadcast a request per node. This commit converts upgrade action to this new model as well. Closes #13204
|
LGTM |
jasontedor
added a commit
that referenced
this pull request
Aug 31, 2015
Convert upgrade action to broadcast by node
|
Thanks for reviewing @bleskes. I've merged this to master and integrated it into to 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several shard-level operations that previously broadcasted a request
per shard were converted to broadcast a request per node. This commit
converts upgrade action to this new model as well.
Closes #13204