Refactor ignore_malformed and coerce GeoPointFieldType to Builder #13289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nknize
added
review
:Analytics/Geo
| if (ignoreMalformed != null) { | ||
| return new Explicit<>(ignoreMalformed, true); | ||
| } | ||
| if (context.indexSettings() != null) { |
There was a problem hiding this comment.
Hrm, I hate adding another use looking up an index setting within mappings. I know the other field mappers do this, but I was hoping to remove this setting sometime soon. @clintongormley do you think we need to support this here?
|
LGTM |
This commit moves ignore_malformed and coerce options from the GeoPointFieldType to the Builder in GeoPointFieldMapper. This makes these options consistent with other types in 2.0.
nknize
force-pushed
the
enhancement/13285
branch
from
251a6b6
to
17460ae
Compare
clintongormley
added
v2.0.0-beta2
>enhancement
and removed
v2.0.0
:Analytics/Geo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
ignore_malformedandcoercefrom theGeoPointFieldTypeto theBuilderinGeoPointFieldMappersince they are only needed at parse time. This makes these options consistent with the behavior of other ES core types.closes #13285