Improve situation when network.host is set to wildcard (e.g. 0.0.0.0) #13299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users might specify something like -Des.network.host=0.0.0.0, as that was the old default with previous versions of elasticsearch. This means to bind to all interfaces, but it makes no sense as a publish address. Pick a good one in this case, just like we do in other cases where publish isn't explicitly specified and we are bound to multiple (e.g. when configured by interface, or dns hostname with multiple addresses). However, in this case warn the user about it: since its arbitrarily picking the first non-loopback address like the old versions did, thats a little too heuristical, but lets make the cutover easy. Separately, fail hard if things like multicast or broadcast addresses are configured as bind or publish addresses, as that is simply invalid. Closes elastic#13274
|
LGTM |
rmuir
added a commit
that referenced
this pull request
Sep 3, 2015
Improve situation when network.host is set to wildcard (e.g. 0.0.0.0)
clintongormley
added
the
:Distributed/Network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users might specify something like -Des.network.host=0.0.0.0, as that
was the old default with previous versions of elasticsearch. This means
to bind to all interfaces, but it makes no sense as a publish address.
Pick a good one in this case, just like we do in other cases where
publish isn't explicitly specified and we are bound to multiple (e.g.
when configured by interface, or dns hostname with multiple addresses).
However, in this case warn the user about it: since its arbitrarily
picking the first non-loopback address like the old versions
did, thats a little too heuristical, but lets make the cutover easy.
Separately, fail hard if things like multicast or broadcast addresses are
configured as bind or publish addresses, as that is simply invalid.
Closes #13274