Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terms Agg filtering values using array of values works but not documented #13352

Closed
nezda opened this issue Sep 4, 2015 · 4 comments
Closed
Assignees
Labels
:Analytics/Aggregations Aggregations >docs General docs changes good first issue low hanging fruit

Comments

@nezda
Copy link

nezda commented Sep 4, 2015

#6782 which I think was fixed in 1.5 series is not reflected in the current docs of https://www.elastic.co/guide/en/elasticsearch/reference/1.7/search-aggregations-bucket-terms-aggregation.html#_filtering_values. Could borrow content from https://www.elastic.co/guide/en/elasticsearch/reference/1.7/search-facets-terms-facet.html#_excluding_terms

@clintongormley clintongormley added >docs General docs changes good first issue low hanging fruit help wanted adoptme :Analytics/Aggregations Aggregations labels Sep 6, 2015
@clintongormley
Copy link

@markharwood looks like your doc changes in #7529 got lost somehow?

@markharwood
Copy link
Contributor

@clintongormley Don't think I dropped anything here?

The opening paragraph says based on regular expression strings or arrays of exact values.
I'm not sure we need to provide an example of what an array of strings looks like here?

@nezda
Copy link
Author

nezda commented Sep 7, 2015

Mea culpa - I didn't read text carefully and was looking for the example in separate section from regexes like it was in Facet docs (which I personally prefer).

@clintongormley
Copy link

@markharwood turns out it was my fault - i removed the example you had from the 1.x docs. Added back here: 63f4af5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Aggregations Aggregations >docs General docs changes good first issue low hanging fruit
Projects
None yet
Development

No branches or pull requests

3 participants