Engine: Let AlreadyClosedException and EngineClosedExceptionBubble up #13380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw ex; | ||
| maybeFailEngine("force merge", new ForceMergeFailedEngineException(shardId, t)); | ||
| // wrap things we don't know in a ForceMergeFailedEngineException but let exceptions that indicate a closed shard bubble up | ||
| if (t instanceof AlreadyClosedException) { |
There was a problem hiding this comment.
can we put it in their own catch clause similar in how it's done in refresh:
} catch (AlreadyClosedException e) {
ensureOpen();
maybeFailEngine("refresh", e);
} catch (EngineClosedException e) {
throw e;
} catch (Throwable t) {
failEngine("refresh failed", t);
throw new RefreshFailedEngineException(shardId, t);
}
There was a problem hiding this comment.
I think we should just rethrow t and remove that exception. We can't handle this just like refresh since a failing refresh means dataloss while this one might just be a configuration issue or so. We should just pass t to maybeFailEngine and rethrow IMO
|
Thx @brwe . Left some comments |
brwe
force-pushed
the
exception-on-force-merge
branch
3 times, most recently
from
d912267
to
f2777bd
Compare
| @@ -865,9 +866,8 @@ public void forceMerge(final boolean flush, int maxNumSegments, boolean onlyExpu | |||
| store.decRef(); | |||
| } | |||
| } catch (Throwable t) { | |||
| ForceMergeFailedEngineException ex = new ForceMergeFailedEngineException(shardId, t); | |||
There was a problem hiding this comment.
we can delete ForceMergeFailedEngineException now, right? It's not used.
|
Cool. LGTM. left some minor comments - no need for another cycle as far as I'm concerned. |
Whe we call optimize we ignore Exceptions that indicate a closed shard. However, when a shard is closed while an optimize request is in flight it might also trigger an AlreadyClosedException from the IndexWriter when we get the config or ForceMergeFailedEngineException with the EngineClosedException wrapped inside. Because these are not identified as exceptions that indicate a closed shard (TransportActions.isShardNotAvailableException(..)) optimize would sometimes report failures when shards were relocating while optimize was called and sometimes not. This caused weird test failures, see elastic#13266 . Instead, we should let EngineClosedException bubble up and also recognize AlreadyClosedException as an indicator for a closed shard.
brwe
force-pushed
the
exception-on-force-merge
branch
from
f2777bd
to
2288d44
Compare
brwe
added a commit
that referenced
this pull request
Sep 8, 2015
Engine: Let AlreadyClosedException and EngineClosedExceptionBubble up
clintongormley
added
:Distributed/Distributed
clintongormley
removed
the
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whe we call optimize we ignore Exceptions that indicate a closed shard.
However, when a shard is closed while an optimize request is in flight it
might also trigger an AlreadyClosedException from the IndexWriter when we
get the config or ForceMergeFailedEngineException with the EngineClosedException
wrapped inside. Because these are not identified as exceptions that indicate
a closed shard (TransportActions.isShardNotAvailableException(..)) optimize
would sometimes report failures when shards were relocating while optimize was called
and sometimes not. This caused weird test failures, see #13266 .
Instead, we should let EngineClosedException bubble up and also recognize
AlreadyClosedException as an indicator for a closed shard.