Failed to properly ack translog ops during wait on mapping changes #13535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…changes During the second phase of recovery, replayed transaction log entries may need to wait on mapping changes that have not yet propogated to the target node. Currently we correctly replay the operation at a later stage, but we acknowledge the replay request before actually performing the work. Example failure: http://build-us-00.elastic.co/job/es_feature_two_phase_pub/859/
bleskes
added
>bug
review
:Distributed/Recovery
|
@s1monw can you take a look? |
| @@ -304,6 +304,7 @@ public void messageReceived(final RecoveryTranslogOperationsRequest request, fin | |||
| assert recoveryStatus.indexShard().recoveryState() == recoveryStatus.state(); | |||
| try { | |||
| recoveryStatus.indexShard().performBatchRecovery(request.operations()); | |||
| channel.sendResponse(TransportResponse.Empty.INSTANCE); | |||
There was a problem hiding this comment.
man, any chance we can unittest this?
There was a problem hiding this comment.
I would love to have those, but it will be a bigger rewrite - too many incoming dependencies. Next time we re-write something in this class...
|
LGTM left one comment |
bleskes
added a commit
that referenced
this pull request
Sep 13, 2015
…changes During the second phase of recovery, replayed transaction log entries may need to wait on mapping changes that have not yet propagated to the target node. Currently we correctly replay the operation at a later stage, but we acknowledge the replay request before actually performing the work. Example failure: http://build-us-00.elastic.co/job/es_feature_two_phase_pub/859/ Closes #13535
bleskes
added a commit
that referenced
this pull request
Sep 13, 2015
…changes During the second phase of recovery, replayed transaction log entries may need to wait on mapping changes that have not yet propagated to the target node. Currently we correctly replay the operation at a later stage, but we acknowledge the replay request before actually performing the work. Example failure: http://build-us-00.elastic.co/job/es_feature_two_phase_pub/859/ Closes #13535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the second phase of recovery, replayed transaction log entries may need to wait on mapping changes that have not yet propagated to the target node. Currently we correctly replay the operation at a later stage, but we acknowledge the replay request before actually performing the work.
Example failure: http://build-us-00.elastic.co/job/es_feature_two_phase_pub/859/