Use a dedicated id to serialize EsExceptions instead of it's class name. #13629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
since the exception mechanism is new in 2.0 I think this should go into 2.0GA since it prevents subtile bugs and is a minor change. |
|
|
||
| final int maxOrd = 140; | ||
| assert exceptions.size() == maxOrd + 1; | ||
| Constructor<? extends ElasticsearchException>[] mapping = new Constructor[maxOrd + 1]; |
There was a problem hiding this comment.
can we call this idToClass?
|
@bleskes applied review comments |
|
LGTM. |
Classnames change quickly due to refactorings etc. If that happens in a minor release we loose the ability to deserialize the exceptoin coming from another node sicne we today look it up by classname. This change uses a dedicated static id instead of the classname to lookup the actual class.
s1monw
force-pushed
the
fix_exception_serialization
branch
from
7c8cd43
to
af9166d
Compare
lcawl
added
:Core/Infra/Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Classnames change quickly due to refactorings etc. If that happens in a minor release
we loose the ability to deserialize the exceptoin coming from another node sicne we today
look it up by classname. This change uses a dedicated static id instead of the classname
to lookup the actual class.