ByteSizeValue.equals should normalize units #13784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently ByteSizeValue.parse("1GB") is not equal to ByteSizeValue.parse("1024MB")
|
@javanna can you take a look please? |
| return size == sizeValue.size; | ||
| } else { | ||
| return bytes() == sizeValue.bytes(); | ||
| } |
There was a problem hiding this comment.
could we just always use the else branch?
There was a problem hiding this comment.
I tried to avoid conversions in the case when it used to return true (i.e., same units) in order to have the minimal change for performance. Can switch if you feel strongly about it.
There was a problem hiding this comment.
Conversion should be very cheap, so I would prefer to always convert to avoid a branch.
|
@jpountz pushed another commit. |
|
LGTM |
|
thx @jpountz are you +1 on pushing this to 2.0 as well? |
|
It looks like a low-risk fix, so 2.0 works for me. |
bleskes
added a commit
that referenced
this pull request
Sep 25, 2015
currently ByteSizeValue.parse("1GB") is not equal to ByteSizeValue.parse("1024MB")
Closes #13784
bleskes
added a commit
that referenced
this pull request
Sep 25, 2015
currently ByteSizeValue.parse("1GB") is not equal to ByteSizeValue.parse("1024MB")
Closes #13784
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Sep 28, 2015
When a shard becomes in active we trigger a sync flush in order to speed up future recoveries. The sync flush causes a new translog generation to be made, which in turn confuses the IndexingMemoryController making it think that the shard is active. If no documents comes along in the next 5m, the shard is made inactive again , triggering a sync flush and so forth. To avoid this, the IndexingMemoryController is changed to ignore empty translogs when checking if a shard became active. This comes with the price of potentially missing indexing operations which are followed by a flush. This is acceptable as if no more index operation come in, it's OK to leave the shard in active. A new unit test is introduced and comparable integration tests are removed. Relates elastic#13802 Includes a backport of elastic#13784
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Sep 28, 2015
When a shard becomes in active we trigger a sync flush in order to speed up future recoveries. The sync flush causes a new translog generation to be made, which in turn confuses the IndexingMemoryController making it think that the shard is active. If no documents comes along in the next 5m, the shard is made inactive again , triggering a sync flush and so forth. To avoid this, the IndexingMemoryController is changed to ignore empty translogs when checking if a shard became active. This comes with the price of potentially missing indexing operations which are followed by a flush. This is acceptable as if no more index operation come in, it's OK to leave the shard in active. A new unit test is introduced and comparable integration tests are removed. Relates elastic#13802 Includes a backport of elastic#13784 Closes elastic#13824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently ByteSizeValue.parse("1GB") is not equal to ByteSizeValue.parse("1024MB")