Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nuke ES_CLASSPATH appending #13812

Closed
rmuir opened this issue Sep 26, 2015 · 1 comment
Closed

nuke ES_CLASSPATH appending #13812

rmuir opened this issue Sep 26, 2015 · 1 comment
Labels
>breaking >bug v2.0.0-rc1

Comments

@rmuir
Copy link
Contributor

rmuir commented Sep 26, 2015

Out of box, ES expects its stuff to be in particular places. We should not be appending to ES_CLASSPATH, allowing users to specify stuff there, like we do in elasticsearch.bin.sh

If the user sets it, its not going to work out of box.
@rjernst
Copy link
Member

rjernst commented Sep 26, 2015

+1 to nuke this. Users shouldnt be adding jars to the classpath.

rmuir added a commit to rmuir/elasticsearch that referenced this issue Sep 30, 2015
@rmuir
Nuke ES_CLASSPATH appending
0406b56 
Out of box, ES expects its stuff to be in particular places. We should not be appending to ES_CLASSPATH, allowing users to specify stuff there, like we do in elasticsearch.bin.sh

If the user sets it, its not going to work out of box.

Closes elastic#13812
@rmuir rmuir mentioned this issue Sep 30, 2015
Closed
@rmuir rmuir closed this as completed in 8c4bc7d Sep 30, 2015
rmuir added a commit that referenced this issue Oct 1, 2015
@rmuir
Nuke ES_CLASSPATH appending, JarHell fail on empty classpath elements
834c396 
Closes #13880

Squashed commit of the following:

commit 316a328
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:57:47 2015 -0400

    windows is terrible

commit 0406b56
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:43:09 2015 -0400

    Nuke ES_CLASSPATH appending

    Out of box, ES expects its stuff to be in particular places. We should not be appending to ES_CLASSPATH, allowing users to specify stuff there, like we do in elasticsearch.bin.sh

    If the user sets it, its not going to work out of box.

    Closes #13812

commit 415d897
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:26:35 2015 -0400

    Fail hard on empty classpath elements.

    This can happen easily, if somehow old 1.x shellscripts survive and try to launch 2.x code.
    I have the feeling this happens maybe because of packaging upgrades or something.
    Either way: we can just fail hard and clear in this situation, rather than the current situation
    where CWD might be /, and we might traverse the entire filesystem until we hit an error...

    Relates to #13864
rmuir added a commit that referenced this issue Oct 1, 2015
@rmuir
Nuke ES_CLASSPATH appending, JarHell fail on empty classpath elements
367e2e2 
Closes #13880

Squashed commit of the following:

commit 316a328
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:57:47 2015 -0400

    windows is terrible

commit 0406b56
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:43:09 2015 -0400

    Nuke ES_CLASSPATH appending

    Out of box, ES expects its stuff to be in particular places. We should not be appending to ES_CLASSPATH, allowing users to specify stuff there, like we do in elasticsearch.bin.sh

    If the user sets it, its not going to work out of box.

    Closes #13812

commit 415d897
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:26:35 2015 -0400

    Fail hard on empty classpath elements.

    This can happen easily, if somehow old 1.x shellscripts survive and try to launch 2.x code.
    I have the feeling this happens maybe because of packaging upgrades or something.
    Either way: we can just fail hard and clear in this situation, rather than the current situation
    where CWD might be /, and we might traverse the entire filesystem until we hit an error...

    Relates to #13864

Conflicts:
	core/src/main/java/org/elasticsearch/bootstrap/JarHell.java
rmuir added a commit that referenced this issue Oct 1, 2015
@rmuir
Nuke ES_CLASSPATH appending, JarHell fail on empty classpath elements
c4eeefb 
Closes #13880

Squashed commit of the following:

commit 316a328
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:57:47 2015 -0400

    windows is terrible

commit 0406b56
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:43:09 2015 -0400

    Nuke ES_CLASSPATH appending

    Out of box, ES expects its stuff to be in particular places. We should not be appending to ES_CLASSPATH, allowing users to specify stuff there, like we do in elasticsearch.bin.sh

    If the user sets it, its not going to work out of box.

    Closes #13812

commit 415d897
Author: Robert Muir <rmuir@apache.org>
Date:   Wed Sep 30 16:26:35 2015 -0400

    Fail hard on empty classpath elements.

    This can happen easily, if somehow old 1.x shellscripts survive and try to launch 2.x code.
    I have the feeling this happens maybe because of packaging upgrades or something.
    Either way: we can just fail hard and clear in this situation, rather than the current situation
    where CWD might be /, and we might traverse the entire filesystem until we hit an error...

    Relates to #13864

Conflicts:
	core/src/main/java/org/elasticsearch/bootstrap/JarHell.java

Conflicts:
	core/src/main/java/org/elasticsearch/bootstrap/JarHell.java
	core/src/test/java/org/elasticsearch/bootstrap/JarHellTests.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>breaking >bug v2.0.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Nuke ES_CLASSPATH appending, JarHell fail on empty classpath elements rmuir/elasticsearch
3 participants
@rjernst @rmuir @spinscale