TransportNodesAction shouldn't hold on to cluster state #13948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -96,15 +97,16 @@ protected boolean transportCompress() { | |||
| private final NodesRequest request; | |||
| private final String[] nodesIds; | |||
| private final ActionListener<NodesResponse> listener; | |||
| private final ClusterState clusterState; | |||
| ImmutableOpenMap<String, DiscoveryNode> nodes; | |||
There was a problem hiding this comment.
why not just resolve this at the start method and not keep this variable as well?
|
left one question... |
imotov
force-pushed
the
optimize-transport-node-operation-action
branch
from
099051c
to
b740d1a
Compare
|
@bleskes is this what you had in mind? |
|
LGTM |
|
LGTM too |
Long running TransportNodesAction requests can retain old cluster states in memory for much longer than needed. This can cause nodes with frequent cluster state updates and long running requests to run out of memory.
imotov
force-pushed
the
optimize-transport-node-operation-action
branch
from
b740d1a
to
ea99d97
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long running TransportNodesAction requests can retain old cluster states in memory for much longer than needed. This can cause nodes with frequent cluster state updates and long running requests to run out of memory.
This problem is especially pronounced on large tribe nodes that send a large number of node requests and have frequently updated cluster state.