Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add T (on top of :, -, and /) as a way to pre detect of a string is a date for dynamic date formats #1694

Closed
kimchy opened this issue Feb 12, 2012 · 4 comments
Closed

Add T (on top of :, -, and /) as a way to pre detect of a string is a date for dynamic date formats #1694

kimchy opened this issue Feb 12, 2012 · 4 comments
Labels
>enhancement help wanted adoptme :Search/Mapping Index mappings, including merging and defining field types

Comments

@kimchy
Copy link
Member

kimchy commented Feb 12, 2012

No description provided.

@kimchy kimchy mentioned this issue Feb 12, 2012
Closed
@kimchy
Copy link
Member Author

kimchy commented Feb 12, 2012

This is problematic, unless we find a good solution for it, since 1T parses fine with the dateOptionalTime parser.

@clintongormley clintongormley mentioned this issue Aug 8, 2014
Merged
@clintongormley
Copy link

Depends on #6227

@spinscale spinscale mentioned this issue May 5, 2015
Closed
@clintongormley clintongormley mentioned this issue May 25, 2015
Closed
@jpountz
Copy link
Contributor

jpountz commented Sep 11, 2015 •
edited

Removing the stalled label as #6227 is fixed now.

@jpountz jpountz removed the stalled label Sep 11, 2015
@clintongormley clintongormley added the help wanted adoptme label Sep 19, 2015
@spinscale spinscale added v2.3.0 and removed v2.2.0 labels Dec 23, 2015
@clintongormley clintongormley mentioned this issue Dec 9, 2016
Closed
@jpountz
Copy link
Contributor

jpountz commented Dec 9, 2016 •
edited

Discussed in FixitFriday: we might want to remove this list of characters entirely and test the list of dynamic date formats on every unmapped field. This sould fix #10961 as well. Performance is not a concern as mappings are expected to converge quickly as more documents are added.

jpountz added a commit to jpountz/elasticsearch that referenced this issue Dec 14, 2016
@jpountz
Date detection should not rely on a hardcoded set of characters.
5df2994 
Currently we only apply date detection on strings that contain either `:`, `-`
or `/`. This commit inverses the heuristic in order to only apply date detection
on strings that are not parseable as a number, so that more date formats can be
used as dynamic dates formats.

Closes elastic#1694
@jpountz jpountz mentioned this issue Dec 14, 2016
Merged
jpountz added a commit that referenced this issue Dec 22, 2016
@jpountz
Date detection should not rely on a hardcoded set of characters. (#22171
9b3b693 
)

Currently we only apply date detection on strings that contain either `:`, `-`
or `/`. This commit inverses the heuristic in order to only apply date detection
on strings that are not parseable as a number, so that more date formats can be
used as dynamic dates formats.

Closes #1694
@clintongormley clintongormley added :Search/Mapping Index mappings, including merging and defining field types and removed :Dates labels Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>enhancement help wanted adoptme :Search/Mapping Index mappings, including merging and defining field types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kimchy @clintongormley @jpountz @spinscale