Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testCorruptTranslogTruncationOfReplica fails on checkIndex #25817

Closed
bleskes opened this issue Jul 20, 2017 · 0 comments · Fixed by #25852
Closed

testCorruptTranslogTruncationOfReplica fails on checkIndex #25817

bleskes opened this issue Jul 20, 2017 · 0 comments · Fixed by #25852
Assignees
@bleskes
Labels
>test Issues or PRs that are addressing/adding tests

Comments

@bleskes
Copy link
Contributor

bleskes commented Jul 20, 2017

example: https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+intake/76/

FAILURE 0.46s J0 | TruncateTranslogIT.testCorruptTranslogTruncationOfReplica <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: at least one shard failed CheckIndex
   > 	at __randomizedtesting.SeedInfo.seed([3132416A541FE03E:1C1C1DE115498AB5]:0)
   > 	at org.elasticsearch.test.ESTestCase.ensureCheckIndexPassed(ESTestCase.java:430)

This has to do with a concurrency issue between shard failures and node shutdown. I have a fix plan and I'll get to this as soon as I can.
@bleskes bleskes added the >test Issues or PRs that are addressing/adding tests label Jul 20, 2017
@bleskes bleskes self-assigned this Jul 20, 2017
bleskes added a commit that referenced this issue Jul 20, 2017
@bleskes
awaitFix testCorruptTranslogTruncationOfReplica
de6ad7a 
see #25817
@bleskes bleskes mentioned this issue Jul 24, 2017
Merged
bleskes added a commit that referenced this issue Jul 25, 2017
@bleskes
Engine.close should only return when resources are freed (#25852)
cd50855 
Currently Engine.close can return immediately if the engine is already at the process of shutting down (due to a concurrent close call or an engine failure). This is a shame because some of our testing infra wants to do things like checking the index. This commit changes the logic to make sure that all calls to close wait until resources are freed. Failing the engine is still non blocking.

Fixes #25817
bleskes added a commit that referenced this issue Jul 25, 2017
@bleskes
Engine.close should only return when resources are freed (#25852)
9c309b3 
Currently Engine.close can return immediately if the engine is already at the process of shutting down (due to a concurrent close call or an engine failure). This is a shame because some of our testing infra wants to do things like checking the index. This commit changes the logic to make sure that all calls to close wait until resources are freed. Failing the engine is still non blocking.

Fixes #25817
bleskes added a commit that referenced this issue Jul 25, 2017
@bleskes
Engine.close should only return when resources are freed (#25852)
1596b56 
Currently Engine.close can return immediately if the engine is already at the process of shutting down (due to a concurrent close call or an engine failure). This is a shame because some of our testing infra wants to do things like checking the index. This commit changes the logic to make sure that all calls to close wait until resources are freed. Failing the engine is still non blocking.

Fixes #25817
bleskes added a commit that referenced this issue Jul 25, 2017
@bleskes
Engine.close should only return when resources are freed (#25852)
6f83edd 
Currently Engine.close can return immediately if the engine is already at the process of shutting down (due to a concurrent close call or an engine failure). This is a shame because some of our testing infra wants to do things like checking the index. This commit changes the logic to make sure that all calls to close wait until resources are freed. Failing the engine is still non blocking.

Fixes #25817
bleskes added a commit that referenced this issue Jul 25, 2017
@bleskes
Engine.close should only return when resources are freed (#25852)
c8a375a 
Currently Engine.close can return immediately if the engine is already at the process of shutting down (due to a concurrent close call or an engine failure). This is a shame because some of our testing infra wants to do things like checking the index. This commit changes the logic to make sure that all calls to close wait until resources are freed. Failing the engine is still non blocking.

Fixes #25817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bleskes bleskes

Labels
>test Issues or PRs that are addressing/adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Engine.close should only return when resources are freed bleskes/elasticsearch
1 participant
@bleskes