Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting index.warmer.enabled is undocumented #29529

Open
DaveCTurner opened this issue Apr 16, 2018 · 5 comments
Open

Setting index.warmer.enabled is undocumented #29529

DaveCTurner opened this issue Apr 16, 2018 · 5 comments
Labels
>deprecation :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team

Comments

@DaveCTurner
Copy link
Contributor

The documentation for the index.warmer.enabled setting was lost in f123a53. It was almost entirely a link to the documentation about index warmers that no longer exists:

See <<indices-warmers>>. Defaults to `true`.

@DaveCTurner DaveCTurner added >bug >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Apr 16, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@jrodewig
Copy link
Contributor

jrodewig commented Mar 27, 2019

Hi @DaveCTurner

It looks like index warmers were deprecated in 2.3:
https://www.elastic.co/guide/en/elasticsearch/reference/2.4/indices-warmers.html

There also appear to be no links to indices-warmers in the current documentation.

Are you comfortable with me closing this ticket?

@DaveCTurner
Copy link
Contributor Author

Hi @jrodewig, the index.warmer.enabled setting still exists in master:

public static final Setting<Boolean> INDEX_WARMER_ENABLED_SETTING =
Setting.boolSetting("index.warmer.enabled", true, Property.Dynamic, Property.IndexScope);

Although it does much less than what it used to in the 2.x series it still does something. I think we should either document it or remove it.

@jrodewig jrodewig removed their assignment Mar 27, 2019
@jimczi
Copy link
Contributor

jimczi commented Apr 2, 2019

We discussed this issue internally and decided that we should remove this setting. Today it is used for two things:

  • To load the global ordinals if eager_global_ordinals is set on the field.
  • To load the bitset filters for all nested fields present in the mapping.
    The former can be controlled on a per field basis while the latter can be controlled with another setting called index.load_fixed_bitset_filters_eagerly so there's no need to keep index.warmer.enabled at all.

@jimczi jimczi added help wanted adoptme and removed team-discuss labels Apr 2, 2019
@jimczi jimczi removed >bug >docs General docs changes labels May 27, 2019
@rjernst rjernst added the Team:Search Meta label for search team label May 4, 2020
@javanna javanna added >deprecation and removed help wanted adoptme labels May 3, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>deprecation :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team
Projects
None yet
Development

No branches or pull requests

7 participants