Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Failure in SslIntegrationTests.testThatTransportClientUsingSSLv3ProtocolIsRejected #35360

Closed
tvernum opened this issue Nov 8, 2018 · 5 comments · Fixed by #36102
Closed

[CI] Failure in SslIntegrationTests.testThatTransportClientUsingSSLv3ProtocolIsRejected #35360

tvernum opened this issue Nov 8, 2018 · 5 comments · Fixed by #36102
Labels
:Security/TLS SSL/TLS, Certificates >test-failure Triaged test failures from CI

Comments

@tvernum
Copy link
Contributor

tvernum commented Nov 8, 2018

This seems to have been broken in #35144 / f395b1e.
Reproduces locally.

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+matrix-java-periodic/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=java11,nodes=virtual&&linux/45/console

./gradlew :x-pack:plugin:security:test -Dtests.seed=447D7874AF93DCF8 -Dtests.class=org.elasticsearch.xpack.security.transport.ssl.SslIntegrationTests -Dtests.method="testThatTransportClientUsingSSLv3ProtocolIsRejected" -Dtests.security.manager=true -Dtests.locale=nl-NL -Dtests.timezone=UCT -Dcompiler.java=11 -Druntime.java=11

  > Throwable #1: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=160, name=Thread-1, state=RUNNABLE, group=TGRP-SslIntegrationTests]
   >    at __randomizedtesting.SeedInfo.seed([447D7874AF93DCF8:9CD5162256A743F1]:0)
   > Caused by: java.lang.AssertionError
   >    at __randomizedtesting.SeedInfo.seed([447D7874AF93DCF8]:0)
   >    at io.netty.handler.ssl.SslHandler.handshake(SslHandler.java:1747)
   >    at io.netty.handler.ssl.SslHandler.startHandshakeProcessing(SslHandler.java:1666)
   >    at io.netty.handler.ssl.SslHandler.channelActive(SslHandler.java:1807)
@tvernum tvernum added >test-failure Triaged test failures from CI :Security/TLS SSL/TLS, Certificates labels Nov 8, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

@tvernum
Copy link
Contributor Author

tvernum commented Nov 8, 2018

Ping: @tbrooks8 - I think this broke in your recent change

@tvernum
Copy link
Contributor Author

tvernum commented Nov 8, 2018

I muted this test (0b24c4f)

tvernum added a commit that referenced this issue Nov 8, 2018
@tvernum
Test: Mute failing SSL test
0b24c4f 
Relates: #35360
@Tim-Brooks
Copy link
Contributor

Tim-Brooks commented Nov 8, 2018 •
edited

I think this has exposed a bug in netty. I opened an issue.

netty/netty#8479

tvernum added a commit that referenced this issue Nov 9, 2018
@tvernum
Test: Mute failing SSL test
2d30420 
Relates: #35360
@tvernum
Copy link
Contributor Author

tvernum commented Nov 9, 2018

This has been muted on 6.x as well.

pgomulka pushed a commit to pgomulka/elasticsearch that referenced this issue Nov 13, 2018
@tvernum @pgomulka
Test: Mute failing SSL test
58c87b6 
Relates: elastic#35360
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Nov 30, 2018
@Tim-Brooks
Upgrade Netty 4.3.32.Final
365ad51 
This commit upgrades netty. This will close elastic#35360. Netty started
throwing an `IllegalArgumentException` if a `CompositeByteBuf` is
created with < 2 components. `Netty4Utils` was updated to reflect this
change.
@Tim-Brooks Tim-Brooks mentioned this issue Nov 30, 2018
Merged
Tim-Brooks added a commit that referenced this issue Nov 30, 2018
@Tim-Brooks
Upgrade Netty 4.3.32.Final (#36102)
370472b 
This commit upgrades netty. This will close #35360. Netty started
throwing an IllegalArgumentException if a CompositeByteBuf is
created with < 2 components. Netty4Utils was updated to reflect this
change.
Tim-Brooks added a commit to Tim-Brooks/elasticsearch that referenced this issue Nov 30, 2018
@Tim-Brooks
Upgrade Netty 4.3.32.Final (elastic#36102)
0955624 
This commit upgrades netty. This will close elastic#35360. Netty started
throwing an IllegalArgumentException if a CompositeByteBuf is
created with < 2 components. Netty4Utils was updated to reflect this
change.
@Tim-Brooks Tim-Brooks mentioned this issue Nov 30, 2018
Merged
Tim-Brooks added a commit that referenced this issue Nov 30, 2018
@Tim-Brooks
Upgrade Netty 4.3.32.Final (#36102) (#36121)
4b1d241 
This commit upgrades netty. This will close #35360. Netty started
throwing an IllegalArgumentException if a CompositeByteBuf is
created with < 2 components. Netty4Utils was updated to reflect this
change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Security/TLS SSL/TLS, Certificates >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Netty 4.3.32.Final Tim-Brooks/elasticsearch
3 participants
@Tim-Brooks @tvernum @elasticmachine