RPMs: Add timeout to shutdown with KILL signal #4721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
If the thread pools of an elasticsearch node cannot be shutdown immediately, a wait of 10 seconds is added. This clashes with the RPM scripts, as by default the init functions wait for 3 seconds for a service to shutdown before a KILL signal is sent, resulting in an unclean shutdown - not from an elasticsearch point of view, but from init system point of view, as some lock files are left around. In order to prevent this the init script as well as the systemd configuration now feature the same timeout than the debian package, which is 20 seconds. The await statement, which causes the 10 second delay can be found in InternalNode.close()
clintongormley
added
>bug
v0.90.11
v1.0.0
v1.1.0
v2.0.0-beta1
v1.0.0.RC2
:Delivery/Packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the thread pools of an elasticsearch node cannot be shutdown
immediately, a wait of 10 seconds is added. This clashes with the
RPM scripts, as by default the init functions wait for 3 seconds
for a service to shutdown before a KILL signal is sent, resulting
in an unclean shutdown - not from an elasticsearch point of view,
but from init system point of view, as some lock files are left
around.
In order to prevent this the init script as well as the systemd
configuration now feature the same timeout than the debian package,
which is 20 seconds.
The await statement, which causes the 10 second delay can be found in
InternalNode.close()
Closes #5020