REST API: Consistent get field mapping response #4822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -88,6 +97,7 @@ public void onResponse(GetFieldMappingsResponse response) { | |||
|
|
|||
| @Override | |||
| public void onFailure(Throwable e) { | |||
| logger.error("OnFailure", e); | |||
|
left one small comment! really good solution - thanks for the extra iteration! LGTM |
If a get field mapping request is issued, and all but the field can be found, the response should return an empty JSON object instead of a 404. Closes elastic#4738
clintongormley
added
>enhancement
v1.1.0
v2.0.0-beta1
v1.0.0.RC2
:Core/Infra/REST API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a get field mapping request is issued, and all but the field can be
found, the response should return an empty JSON object instead of a 404.
Closes #4738