Add throttling to snaphost and restore operations #4891
Conversation
|
+1, tested this locally and it works great. |
| } | ||
|
|
||
| @Override | ||
| public int read(byte[] b) throws IOException { |
There was a problem hiding this comment.
maybe you can just delegate to read(byte[],int,int)
|
left some minor comments otherwise LGTM |
| public int read() throws IOException { | ||
| int b = delegate.read(); | ||
| if (b > 0) { | ||
| listener.onPause(rateLimiter.pause(1)); |
There was a problem hiding this comment.
I meant something like this:
long pause = rateLimiter.pause(1);
if (pause > 0) {
listerner.onPause(pause);
}
There was a problem hiding this comment.
It would be inconsistent with RateLimitedFSDirectory.Listener I also think that onPause(0) might be useful in certain cases. However, it should be if (b >= 0) {
There was a problem hiding this comment.
well this one is entirely different. It's a buffered input that only calls that on a flush which is every 8kb or so. This one is called for every byte? and I disagree as well on the >= though it should only be called if really needed
There was a problem hiding this comment.
I meant b >= 0 in case of bytes, not nanoseconds. In practice, this method is never called anyway, since none of the current implementations of blob store are using it to copy indices to a repository and I really hope they never will (it will be really bad performance decision anyway) So, if you feel strongly about (theoretically) not calling pause for every byte, I will implement your solution.
|
LGTM |
clintongormley
added
>enhancement
v1.1.0
v2.0.0-beta1
v1.0.0.RC2
:Distributed/Snapshot/Restore
Closes #4855