Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtermvectors REST API should support source parameter #4910

Closed
wants to merge 1 commit into from
Closed

mtermvectors REST API should support source parameter #4910

wants to merge 1 commit into from

Conversation

dadoonet
Copy link
Member

As stated in documentation, we should support ?source= parameter in msearch REST operations.

This is how to reproduce it:

curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

# This one works
curl -XPOST "http://localhost:9200/test/type/_mtermvectors" -d'
{
    "ids" : ["1"]
}'

# This one gives: "ActionRequestValidationException[Validation Failed: 1: multi term vectors: no documents requested;]"
curl -XGET "http://localhost:9200/test/type/_mtermvectors?source=%7B%22ids%22%3A%5B%221%22%5D%7D"

Closes #4902.

@dadoonet
mtermvectors REST API should support source parameter
4308474 
As stated in documentation, we should support `?source=` parameter in msearch REST operations.

This is how to reproduce it:

```sh
curl -XDELETE "http://localhost:9200/test"

curl -XPOST "http://localhost:9200/test/type/1?refresh" -d'{
    "foo": "bar"
}'

# This one works
curl -XPOST "http://localhost:9200/test/type/_mtermvectors" -d'
{
    "ids" : ["1"]
}'

# This one gives: "ActionRequestValidationException[Validation Failed: 1: multi term vectors: no documents requested;]"
curl -XGET "http://localhost:9200/test/type/_mtermvectors?source=%7B%22ids%22%3A%5B%221%22%5D%7D"
```

Closes elastic#4902.
@ghost ghost assigned dadoonet Jan 27, 2014
@dadoonet
Copy link
Member Author

Merged in:

  • 1.0
  • 1.x
  • master

@dadoonet dadoonet closed this Jan 28, 2014
@dadoonet dadoonet deleted the issue/4902-mvectors-source branch January 28, 2014 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dadoonet dadoonet

Labels
>bug :Core/Infra/REST API REST infrastructure and utilities v1.0.0.RC2 v1.1.0 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mtermvectors REST API should support source parameter
2 participants
@dadoonet @clintongormley